fix(app-shell): forward usb request errors and log #15959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were swallowing all errors from usb requests, which doesn't seem like a great idea - it definitely led to lots of errors in browser logs. While we're at it, let's get some more in-detph logging of usb requests.
sfoster1
requested review from
jerader,
shlokamin and
mjhuff
and removed request for
a team
mjhuff
approved these changes
Aug 21, 2024
| @@ -94,6 +94,19 @@ function reconstructFormData(ipcSafeFormData: IPCSafeFormData): FormData { | |||
| return result | |||
| } | |||
|
|
|||
| const cloneError = (e: any): Record<string, unknown> => | |||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-argument | |||
| Object.entries(axios.isAxiosError(e) ? e.toJSON() : e).reduce< | |||
There was a problem hiding this comment.
Just curious, in practice, is this ever not an axios error? It's probably safer to do this regardless.
There was a problem hiding this comment.
not as far as I know, but this way if we ever make a new bug it will at least get reported in the browser logs
| return await remote.ipcRenderer.invoke('usb:request', configProxy) | ||
| const result = await remote.ipcRenderer.invoke('usb:request', configProxy) | ||
| if (result?.error != null) { | ||
| throw result.error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were swallowing all errors from usb requests, which doesn't seem like a great idea - it definitely led to lots of errors in browser logs.
Fixing this by propagating the errors back across the IPC allows the browser-side tanstack query stuff to actually notice that there were errors. Previously, those queries would just come back with
undefined, and stuff higher up the stack would see that its maintenance run data wasundefined, which is not something we test for or care about.This seems to be a magic bullet that fixes various USB stability issues; I'm a bit suspicious of it solving everything, but in my testing it solves some things and it certainly can't hurt.
Closes RQA-2931 RQA-2933