fix(app, odd): run summery error list bug fixes #15953
Conversation
TamarZanzouri
requested review from
smb2268,
sfoster1 and
mjhuff
and removed request for
a team and
smb2268
| @@ -43,7 +43,6 @@ export function ModalHeader(props: ModalHeaderBaseProps): JSX.Element { | |||
| color={iconColor} | |||
| size="2rem" | |||
| alignSelf={ALIGN_CENTER} | |||
| marginRight={SPACING.spacing16} | |||
There was a problem hiding this comment.
really? this will affect all the rest of the modals on the ODD
There was a problem hiding this comment.
we have a gap in the div above it. I think we can remove this. can test more if needed!
app/src/organisms/OnDeviceDisplay/RunningProtocol/RunFailedModal.tsx
Outdated
Show resolved
Hide resolved
| @@ -95,7 +107,9 @@ export function RunFailedModal({ | |||
| errorType: errors[0].errorType, | |||
| errorCode: errors[0].errorCode, | |||
| }) | |||
| : `${errors.length} errors`} | |||
| : `${errors.length} ${ | |||
| runStatus === RUN_STATUS_SUCCEEDED ? t('warning') : t('error') | |||
There was a problem hiding this comment.
this won't translate properly, right? if you translated it into say chinese, if there was more than one error it would have an "s" at the end of the chinese characters, and because the translation isn't number-aware it wouldn't have the right counting word. we should be using the i18n pluralization tools here
| title: | ||
| commandErrorList == null || commandErrorList?.data.length === 0 | ||
| ? t('run_failed_modal_title') | ||
| : runStatus === RUN_STATUS_SUCCEEDED |
we probably need to update the packages. will do this in another pr/release. for now reverted the plural changs. |
TamarZanzouri
deleted the
RQA-2923-odd-not-showing-view-error-details-for-a-run-that-ended-with-errors
branch
Overview
Closes RQA-2923.
show warnings/errors depending on the run status.
modal header.
show error details on ODD if run completed with errors.
Test Plan and Hands on Testing
Changelog
RunFailedModal.Risk assessment
low. bug fixes.