Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): create file wizard redesign skeleton #15944

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Aug 9, 2024

closes AUTH-640

Overview

This was originally supposed to be just the wizard skeleton but then i got carried away and completed a few pages in the flow already that weren't blocked by the component work.

That being said, a few pages are not done yet and will be completed in a follow up. Plus the logic for determining slots for the module placements and fixtures needs to be added as well.

Screen.Recording.2024-08-09.at.10.45.27.mov

Test Plan and Hands on Testing

Turn on the redesign ff and look through the wizard.

The Flex flow should have 6 pages and the OT-2 flow should have 4 pages

Changelog

  • create wizard with each step and wire up the metadata, robotType, gripper pages
  • add tests for the completed pages
  • add skeletons for rest of the pages

Review requests

see test plan

Risk assessment

low, behind ff

@jerader jerader requested review from a team as code owners August 9, 2024 14:47
@jerader jerader requested review from ncdiehl11 and koji and removed request for a team August 9, 2024 14:47
@jerader jerader removed the request for review from a team August 9, 2024 15:28
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!! I didn't do a deep dive comparing to Figma because I am sure we will be DQAing more extensively as we flesh out the content more. Looking forward to continuing this work 👊

@jerader jerader merged commit c3e9087 into edge Aug 12, 2024
48 checks passed
@jerader jerader deleted the pd_create-file-wizard-redesign branch August 12, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants