Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(robot-server): Publish to maintenance_runs/current_run on initial PLAY action #15943

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Aug 9, 2024

Overview

When a client posts a PLAY action that starts a protocol run, any existing maintenance run ID is cleared from the server. This means that MQTT should update subscribers interested in the current maintenance run.

I've decided to follow the existing pattern for how we've handled async/sync publishing in the past, which is create a sync version if one doesn't exist instead of changing the method that uses the publish to async.

Test Plan and Hands on Testing

  • Verified via Postman that the refetch at robot-server/maintenance_runs/current_run occurs when playing a protocol run for the first time that run.

Changelog

  • Fixed starting protocol runs not properly alerting the desktop app and ODD that maintenance runs should be closed.

Risk assessment

low

@mjhuff mjhuff requested review from sfoster1, SyntaxColoring, TamarZanzouri and a team August 9, 2024 13:46
@mjhuff mjhuff requested a review from a team as a code owner August 9, 2024 13:46
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, nice!

@mjhuff
Copy link
Contributor Author

mjhuff commented Aug 9, 2024

Apologies for the quick merge, need this for another PR going up in a few. Will address feedback in a separate PR, if necessary.

@mjhuff mjhuff merged commit 1b0afad into chore_release-8.0.0 Aug 9, 2024
13 checks passed
@mjhuff mjhuff deleted the robot-server_publish-on-play branch August 9, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants