Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app, components): add stacking to non-module stacks #15937

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Aug 8, 2024

Overview

Add stack icon, highlight, and click handling to non-module stacks (example: slot + adapter + labware)

Test Plan and Hands on Testing

  • Upload a protocol with a variety of labware + module + adapter combinations (example)
  • Start a run and proceed to labware setup map view
  • Confirm that stack icon appears on any valid stack
  • Confirm that on desktop, stacks highlight when hovered, even when top labware is adapter. On ODD, all labware is highlighted, even when top labware is adapter
  • Confirm that clicking a stack produces labware stack modal with correct stack elements, special casing 96 tiprack adapter to png

Changelog

  • Special case 96 tiprack adapter to png in LabwareStackModal for desktop
  • Pass correct labware locations in labwareOnDeck to BaseDeck from SetupLabwareMap (desktop component). Pass correct highlight and stacked props
  • Pass correct stacked prop to BaseDeck from LabwareMapView (ODD component)
  • Accommodate highlight in LabwareAdapter

Review requests

see test plan

Risk assessment

medium

Add stack icon, highlight, and click handling to non-module stacks (example: slot + adapter +
labware)
@ncdiehl11 ncdiehl11 requested a review from brenthagen August 8, 2024 19:22
@ncdiehl11 ncdiehl11 marked this pull request as ready for review August 8, 2024 19:31
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner August 8, 2024 19:31
Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked with the provided protocol, looks good. a couple comments about code organization

@ncdiehl11 ncdiehl11 merged commit a9fc050 into chore_release-8.0.0 Aug 9, 2024
34 checks passed
@ncdiehl11 ncdiehl11 deleted the feat_app-nonmodule-stack branch August 9, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants