Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): add public sans to protocol-designer #15932

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Aug 7, 2024

Overview

add public sans to protocol-designer
add GlobalStyle and public sans to pd

close AUTH-643

Screenshot 2024-08-08 at 6 24 46 AM

Screenshot 2024-08-08 at 6 25 50 AM

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

add public sans to protocol-designer

close AUTH-
@koji koji marked this pull request as ready for review August 7, 2024 21:29
@koji koji requested a review from a team as a code owner August 7, 2024 21:29
@koji koji requested review from jerader and removed request for a team August 7, 2024 21:30
<Provider store={store}>
const RootComponent = (): JSX.Element => {
const enableRedesign = useSelector(getEnableRedesign)
console.log('enableRedesign', enableRedesign)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log('enableRedesign', enableRedesign)

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo thanks Koji!!!

@koji koji added the authorship label Aug 7, 2024
@koji
Copy link
Contributor Author

koji commented Aug 7, 2024

@jerader
maybe we could add a few styles that are for the entire app (default font-color, body padding, margin etc)

@koji koji merged commit 807dd49 into edge Aug 7, 2024
13 of 14 checks passed
@koji koji deleted the feat_add-public-sans-to-pd branch August 7, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants