Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, components): fix labware map view selection ODD #15930

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Aug 7, 2024

Overview

Render proper modal depending on if labware is top element of stack or loaded directly on deck. Refactors to use the same state variable to keep track of the selected labware, and determines which modal to show depending on if the selected labware was loaded onto a module/adapter or directly onto the deck.

Test Plan and Hands on Testing

  • upload a protocol on Flex ODD and start run setup
  • navigate to Labware setup -> map view
  • Select various labware and verify that the expected modal is produced: single labware info or labware stack info. Verify that the header location is correct based on the selected labware.

Changelog

  • refactor logic for selected labware, rendering modal depending on if labware is part of a stack
  • pass robotType as optional prop to LabwareStackModal
  • update DeckInfoLabel for thermocycler stack

Review requests

see test plan

Risk assessment

low

Render proper modal depending on if labware is top element of stack or loaded directly on deck.
@ncdiehl11 ncdiehl11 marked this pull request as ready for review August 7, 2024 20:20
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner August 7, 2024 20:20
@ncdiehl11 ncdiehl11 requested review from jerader and removed request for a team August 7, 2024 20:20
Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out and it fixes the white screen from a missing adapter svg and now selects B1 as expected when selecting a labware on top of a thermocycler.

Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested labware selection, LGTM !

@ncdiehl11 ncdiehl11 requested review from smb2268 and brenthagen August 7, 2024 20:31
@ncdiehl11 ncdiehl11 merged commit 8430cd1 into chore_release-8.0.0 Aug 7, 2024
34 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_app-selected-labware-odd branch August 9, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants