refactor(components, app): move LargeButton to components and add helix styling #15929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
force-pushed
the
components_refactor-large-button
branch
from
df6371c to
1f190d9
Compare
koji
reviewed
Aug 7, 2024
| } | ||
| padding: ${SPACING.spacing16} ${SPACING.spacing24}; | ||
| text-align: ${TYPOGRAPHY.textAlignCenter}; | ||
| border-radius: ${BORDERS.borderRadius40}; |
There was a problem hiding this comment.
the design is using 200px but I think 40px would be enough.
There was a problem hiding this comment.
thanks, good catch!
koji
reviewed
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-622
Overview
move
LargeButtonto components for the PD component work.Test Plan and Hands on Testing
review code and review storybook. For the storybook, make sure to manually change the viewport size to see helix vs odd
Changelog
move
LargeButtonto components and update all associated imports. add styling for helixReview requests
see test plan
Risk assessment
low