Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): update the byonoy library to 2024.07.0 [DO NOT MERGE!!] #15928

Closed

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Aug 7, 2024

Overview

We got a new 2024.07.0 library update from Byonoy, this pull request updates the function names and error codes to reflect the new library names. This pull request goes in conjunction with this oe-core pr Opentrons/oe-core#159.

Library Introduces the following changes
`There are two major changes.

  • The name of the Python module has been changed to byonoy_devices
  • The Byonoy prefix has been removed from all datatypes, enumerations, and method names.

There are some bug fixes

  • One bug that has been fixed is the vid/pid which was returning wrong values.
  • Another fix is to remove an unintended busy wait when opening devices.
  • A few other improvements

Test Plan and Hands on Testing

  • Make sure we can still open/free the device
  • Make sure we can read the status of the device and info using the poller
  • Make sure we can still update the device

Changelog

  • Change the name of the AbsorbanceHidInterface functions to match that of the new library
  • Change the name of the ErrorCodeNames to match the new library

Review requests

Risk assessment

Low, unreleased

@vegano1 vegano1 marked this pull request as ready for review August 7, 2024 19:56
@vegano1 vegano1 requested a review from a team as a code owner August 7, 2024 19:56
@vegano1 vegano1 changed the title fix(api): update the byonoy library to 2024.07.0 fix(api): update the byonoy library to 2024.07.0 [DO NOT MERGE!!] Aug 7, 2024
@vegano1
Copy link
Contributor Author

vegano1 commented Aug 7, 2024

There seems to be an issue with firmware updates in this version of the library, need to debug. DO NOT MERGE

@vegano1 vegano1 closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants