Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app,components): add stacked badge to protocol setup labware maps #15925

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

brenthagen
Copy link
Contributor

Overview

adds a stacked badge icon to BaseDeck and uses it in desktop/ODD protocol setup labware maps. adds a highlight on hover for desktop stacked labware on modules.

closes PLAT-372

Screen Shot 2024-08-07 at 2 49 54 PM Screen Shot 2024-08-07 at 2 50 44 PM

Test Plan and Hands on Testing

manually verified badge and hover on desktop/ODD

Changelog

  • Adds stacked badge to protocol setup labware maps
  • Adds a highlight on hover for desktop stacked labware on modules

Review requests

load a protocol with labware on modules, check the badges

Risk assessment

low

adds a stacked badge icon to BaseDeck and uses it in desktop/ODD protocol setup labware maps. adds a
highlight on hover for desktop stacked labware on modules.

closes PLAT-372
@brenthagen brenthagen requested review from smb2268, ncdiehl11 and a team August 7, 2024 19:07
@brenthagen brenthagen requested a review from a team as a code owner August 7, 2024 19:07
@brenthagen brenthagen removed the request for review from a team August 7, 2024 19:07
Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stacked icon location and hover state lgtm!

@brenthagen brenthagen merged commit a6c0ba7 into chore_release-8.0.0 Aug 7, 2024
54 checks passed
@brenthagen brenthagen deleted the app_stacked-badge branch August 7, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants