Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app): fix title element props in LabwareStackModal #15922

Merged
merged 1 commit into from
Aug 7, 2024
Merged

refactor(app): fix title element props in LabwareStackModal #15922

merged 1 commit into from
Aug 7, 2024

Conversation

ncdiehl11
Copy link
Collaborator

Overview

Pass LegacyModal title text and icon elements as separate props in LabwareStackModal

Test Plan and Hands on Testing

  • begin a protocol run for a protocol containing stacked labware/adapeters/modules (example)
  • select Labware setup step -> map view
  • click a stack
  • verify that modal title matches designs specified in linked ticket

Changelog

  • pass separate title props to LegacyModal in LabwareStackModal

Review requests

Please see test plan and ensure code logic is correct.

Risk assessment

low

@ncdiehl11
refactor(app): fix title element props in LabwareStackModal
8249ea0 
Pass `LegacyModal` title text and icon elements as separate props in `LabwareStackModal`
@ncdiehl11 ncdiehl11 marked this pull request as ready for review August 7, 2024 17:58
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner August 7, 2024 17:58
@ncdiehl11 ncdiehl11 requested review from mjhuff, shlokamin and jerader and removed request for a team August 7, 2024 17:58
@ncdiehl11 ncdiehl11 self-assigned this Aug 7, 2024
shlokamin
shlokamin approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncdiehl11 ncdiehl11 merged commit 63fd8fc into chore_release-8.0.0 Aug 7, 2024
26 checks passed
@ncdiehl11 ncdiehl11 deleted the refactor_labwarestackmodal branch August 7, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlokamin shlokamin shlokamin approved these changes

@mjhuff mjhuff Awaiting requested review from mjhuff mjhuff is a code owner automatically assigned from Opentrons/js

@jerader jerader Awaiting requested review from jerader

Assignees

@ncdiehl11 ncdiehl11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncdiehl11 @shlokamin