feat(app): update LegacyModalHeader for new designs #15914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `LegacyModalHeader` according to new designs to accept up to 2 elements ahead of title text. Add props to `LegacyModal` that are passed down to header, and implement at `LabwareStackRender` Closes PLAT-395
ncdiehl11
changed the title
ncdiehl11
requested review from
TamarZanzouri,
shlokamin and
jerader
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update
LegacyModalHeaderaccording to new designs to accept up to 2 elements ahead of title text.Add props to
LegacyModalthat are passed down to header, and implement atLabwareStackRenderCloses PLAT-395
Test Plan and Hands on Testing
begin a protocol run for a protocol containing stacked labware/adapeters/modules (example)
select Labware setup step -> map view
click a stack
verify that modal title matches designs specified in linked ticket
smoke test other instances of
LegacyModal(module calibration, robot update, etc.) to ensure title is unaffected if optionaltitleElementprops are not passedChangelog
titleElementprops toLegacyModalandLegacyModalHeaderLabwraeStackModalReview requests
Risk assessment
low-medium. Minor change adding optional props, but LegacyModal is used extensively in our app