feat(protocol-designer): add landing page #15912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdiehl11
reviewed
Aug 7, 2024
jerader
force-pushed
the
pd_create-landing-pg
branch
from
9c8e3d4 to
b28a671
Compare
Elyorcv
reviewed
Aug 8, 2024
| "import": "Import", | ||
| "next": "next", | ||
| "no-code-solution": "A no-code solution to create protocols that x, y and z meaning for your lab and workflow.", |
There was a problem hiding this comment.
Suggested change
| "no-code-solution": "A no-code solution to create protocols that x, y and z meaning for your lab and workflow.", | |
| "no-code-solution": "A no-code solution to create protocols that x, y and z tailored to your lab and workflow.", |
There was a problem hiding this comment.
thanks for flagging this Elyor! The copy isn't finalized yet - so we will have to go back and fix it after Ed has reviewed everything.
jerader
force-pushed
the
pd_create-landing-pg
branch
from
b28a671 to
14b0f9d
Compare
koji
reviewed
Aug 8, 2024
koji
reviewed
Aug 8, 2024
koji
reviewed
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-639
Overview
added the UI for the landing page since it is in hi-fi.
Test Plan and Hands on Testing
In PD, turn on the redesign ff and look at the landing page! see that the create protocol button goes to the next page and the import link allows you to import. After importing, it should navigate you to the protocol overview page with the path
/overviewChangelog
add ui to the landing page component and wire up the import file button
Review requests
see test plan
Risk assessment
low behind ff