feat(api): Allow omitting description
and display_color
from ProtocolContext.define_liquid()
#15906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes AUTH-633. This is pretty simple and self-contained, so I figured we might as well try to squeeze it in v8.0.
Test Plan and Hands on Testing
Play with different
apiLevel
s for this "protocol":Changelog
define_liquid()
is called without supplying any value fordescription
ordisplay_color
, act as ifNone
was supplied. This takes a little bit of trickery to retain the existing behavior for olderapiLevel
s, which is to require some explicit value, even if that value is justNone
. The new behavior is gated behindapiLevel 2.20
.Review requests
Do we want any of these docstring changes in a different branch?
Risk assessment
Lo.