refactor(api): liquid probe refactor #15903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanthecoder
reviewed
Aug 7, 2024
caila-marashaj
force-pushed
the
liquid-probe-refactor
branch
from
9d9b213 to
5a1ed75
Compare
caila-marashaj
force-pushed
the
liquid-probe-refactor
branch
from
5a1ed75 to
882e781
Compare
sfoster1
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This rearranges
ot3api::liquid_probeto change some variable names and hopefully be a little more readable while not changing any functionality.Test Plan
Review Requests
Please let me know if anything happening or any variable names are still confusing
TODO
Move the magic numbers being used in liquid probe into shared-data in a follow-up pr