Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): deck setup skeleton for redesign #15899

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Aug 6, 2024

closes AUTH-635

Overview

This PR creates a skeleton for the deck setup in the redesign. It is not entirely wired up yet but you should be able to see the deck map and when you hover on the slots, it will show a "slot description" on the left.

Screen.Recording.2024-08-06.at.11.53.50.mov

Test Plan and Hands on Testing

First, with the redesign ff turned off, create a flex protocol and add some labware, modules and liquids to the deck.
Then, turn on the redesign ff and click on "create new protocol". Then click on the "protocol overview" text. You should see a "go to deck setup" button. Click on that and see the deck map view. When you hover over each slot, it should give you the select overlay and a "slot information" text to the left. (see the attached video for an example)

Repeat the steps for an ot-2 protocol. should work the same.

Note: i haven't wired up select yet!!

Changelog

  • create new DeckSetup components under the ProtocolOverview pages
  • add a test case to ProtocolOverview

Review requests

see test plans

Risk assessment

low, behind ff

@jerader jerader requested a review from a team as a code owner August 6, 2024 15:55
@jerader jerader requested review from shlokamin and ncdiehl11 and removed request for a team August 6, 2024 15:55
@jerader jerader requested a review from koji August 6, 2024 15:55
@jerader jerader requested a review from koji August 8, 2024 12:52
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerader jerader merged commit 3a27f06 into edge Aug 8, 2024
14 checks passed
@jerader jerader deleted the pd_new-deck-map branch August 8, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants