Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app): Split RunProgressMeter #15893

Merged
merged 1 commit into from
Aug 5, 2024
Merged

refactor(app): Split RunProgressMeter #15893

merged 1 commit into from
Aug 5, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Aug 5, 2024 •
edited by jira bot
Loading

Closes RQA-2842

Overview

Migrates the logic for building RunProgressMeter's step copy to its own utility, cleaning up the order of operations slightly.

This PR refactors the final step text from nothing "N/A" when the run is canceled before starting.

Current Behavior

Screenshot 2024-07-10 at 3 57 09 PM

Fixed Behavior

Screenshot 2024-08-05 at 3 34 52 PM

Test Plan and Hands on Testing

  • Smoke tested existing copy possibilities.
  • This PR is covered by existing tests and a new one to account for the copy changes.

Changelog

  • Canceling a run before starting it now shows "Final Step: N/A"

Risk assessment

low

@mjhuff mjhuff requested a review from a team August 5, 2024 19:37
@mjhuff mjhuff requested a review from a team as a code owner August 5, 2024 19:37
@mjhuff mjhuff requested review from ncdiehl11 and removed request for a team and ncdiehl11 August 5, 2024 19:37
sfoster1
sfoster1 approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a sucker for separating logic and view that's actually separable

@mjhuff mjhuff merged commit 33dde5e into chore_release-8.0.0 Aug 5, 2024
26 checks passed
@mjhuff mjhuff deleted the app_refactor-run-progress-meter branch August 5, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjhuff @sfoster1