-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(api, robot-server): add get command errors to runs router #15883
feature(api, robot-server): add get command errors to runs router #15883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should change the route from /commands/errors
to /commandErrors
, but other than that, this looks good to me. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some implementation notes, but mostly request-changes because of the route - I agree with @SyntaxColoring, I think this should be a child of /runs/:runid
directly. I support /runs/:runid/errors
rather than /runs/:runid/commandErrors
just because it's shorter and I hate camelcase but obviously that's a matter of taste more than anything else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer, love the new API presentation. I think we probably still want to hoist the cursor defaulting to the robot server but other than that I'm happy with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the return type needs adjusting, but other than that this looks great, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Overview
closes https://opentrons.atlassian.net/browse/EXEC-504.
add an end point in runs router to fetch commands error list.
Test Plan and Hands on Testing
/runs/{runId}/commandErrors
and make sure you are getting the full command error list.Changelog
/runs/{runId}/commandErrors
.CommandsState
toget_error_slice
.Review requests
naming makes sense? changes make sense? location for the new route makes sense? (under commands router)
Risk assessment
low. adding new logic