Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): liquid updates in protocol details and setup for odd & desktop #15882

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Aug 2, 2024

fix PLAT-438, PLAT-440, PLAT-441, PLAT-439, PLAT-442, PLAT-443, PLAT-444

Overview

Updates to liquid details on ODD and desktop protocol details and setup

Test Plan and Hands on Testing

Look at a protocol with liquids and examine liquid details on protocol details and protocol setup

Screen Shot 2024-08-02 at 3 38 09 PM Screen Shot 2024-08-02 at 3 31 23 PM Screen Shot 2024-08-02 at 3 30 57 PM Screen Shot 2024-08-02 at 4 39 15 PM Screen Shot 2024-08-02 at 3 58 41 PM

Changelog

  1. Remove volume column from protocol details view for ODD and desktop
  2. Add column titles to run setup view for liquid name and total volume for ODD and desktop
  3. Change list items in setup view to show volume per well instead of total volume in that labware for ODD and desktop
  4. Show DeckInfoLabel instead of plain slot name for labware location on desktop for Flex only

Review requests

Look at screenshots for matching designs, look over code

Risk assessment

Low

@smb2268 smb2268 requested a review from a team as a code owner August 2, 2024 19:40
@smb2268 smb2268 requested review from brenthagen and removed request for a team August 2, 2024 19:40
@smb2268 smb2268 changed the base branch from edge to chore_release-8.0.0 August 2, 2024 19:42
@smb2268 smb2268 changed the title feat(app): liquid updates in odd protocol details and setup feat(app): liquid updates in protocol details and setup for odd & desktop Aug 2, 2024
@smb2268 smb2268 force-pushed the app_odd-liquid-updates branch from 52f8c4d to e72a68c Compare August 2, 2024 20:45
@smb2268 smb2268 requested review from ncdiehl11 and a team August 2, 2024 21:05
@ecormany
Copy link
Contributor

ecormany commented Aug 5, 2024

We need to round the individual well volume numbers to avoid floating point precision errors. Nearest tenth of a µL should be good.
image

Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after addressing Ed's rounding comment

StyledText,
JUSTIFY_SPACE_BETWEEN,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, move up to alphabetize

color={COLORS.grey60}
marginX={SPACING.spacing16}
>
{liquid.description != null ? liquid.description : null}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like liquids require a description to pass analysis, so this should always be non-null
{liquid.description}

@smb2268 smb2268 merged commit 4500e21 into chore_release-8.0.0 Aug 5, 2024
20 checks passed
@smb2268 smb2268 deleted the app_odd-liquid-updates branch August 5, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants