-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): liquid updates in protocol details and setup for odd & desktop #15882
Conversation
52f8c4d
to
e72a68c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me after addressing Ed's rounding comment
StyledText, | ||
JUSTIFY_SPACE_BETWEEN, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, move up to alphabetize
color={COLORS.grey60} | ||
marginX={SPACING.spacing16} | ||
> | ||
{liquid.description != null ? liquid.description : null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like liquids require a description to pass analysis, so this should always be non-null
{liquid.description}
fix PLAT-438, PLAT-440, PLAT-441, PLAT-439, PLAT-442, PLAT-443, PLAT-444
Overview
Updates to liquid details on ODD and desktop protocol details and setup
Test Plan and Hands on Testing
Look at a protocol with liquids and examine liquid details on protocol details and protocol setup
Changelog
Review requests
Look at screenshots for matching designs, look over code
Risk assessment
Low