chore: update electron-debug #15877
Merged
chore: update electron-debug #15877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update electron-debug
koji
requested review from
sfoster1,
shlokamin,
smb2268,
brenthagen,
ncdiehl11,
mjhuff and
jerader
|
same, thanks @koji! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
update electron-debug version to v3.2.0.
the latest version is v4.0.0 but the requirements are node v18( ✅) and electron v30 (❌)
I think the next Electron update will be in the next release at the earliest.
Test Plan and Hands on Testing
run
make teardown-js && make setup-jsthenmake -C app devcheck you can open chrome dev tools without clicking toggle dev tools a couple of times.
Changelog
Review requests
Risk assessment
low