feat(app): Implement hasEverEnteredErrorRecovery
#15876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
requested review from
ncdiehl11
and removed request for
a team and
ncdiehl11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-636 and EXEC-637 and RQA-2900
Overview
Now that the run can tell us if we've entered Error Recovery, we can:
Show drop tip CTAs conditionally
Because ER always requires the users to go through drop tip flows, it's redundant and mildly annoying for users to see a second set of now irrelevant CTAs. Now, we only show the CTAs at the end of the run if the run did not enter error recovery (and the conditions for detecting potential tip attachment occur).
I earlier hacked something together to make this work on the desktop, but it wasn't possible to do this on the ODD based on how routing logic works. I've cleaned up the desktop to use the same logic that the ODD uses.
Use ODD recovery analytics
There was one analytic that was impossible to implement on the ODD without
hasEverEnteredErrorRecovery(again, due to the way we handle routing), so that is added here, too.Current Behavior
Screen.Recording.2024-08-02.at.11.36.31.AM.mov
New Behavior
Screen.Recording.2024-08-02.at.11.35.22.AM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low