Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix CommandText console warnings #15856

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jul 31, 2024

Overview

Explicitly handle the null command case to prevent warnings. The intention of useCommandTextString after #15708 is to support null commands, so this change genuinely implements the desired behavior.

Test Plan and Hands on Testing

  • Verified no more console spam.

Risk assessment

low

Explictly handle a null command to prevent warnings.
@mjhuff mjhuff requested a review from a team July 31, 2024 17:32
@mjhuff mjhuff requested a review from a team as a code owner July 31, 2024 17:33
@mjhuff mjhuff requested review from shlokamin and removed request for a team and shlokamin July 31, 2024 17:33
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mjhuff mjhuff merged commit 1c059f9 into edge Jul 31, 2024
30 checks passed
@mjhuff mjhuff deleted the app_fix-commandtext-error branch July 31, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants