Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(app): Ignore error this run #15854

Merged
merged 2 commits into from
Jul 31, 2024
Merged

feat(app): Ignore error this run #15854

merged 2 commits into from
Jul 31, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jul 31, 2024 •
edited by jira bot
Loading

Closes EXEC-560 and EXEC-446

Overview

This PR adds support for "ignoring all errors of this type this run". Note that this command is currently only used during the "No liquid detected" recovery flow.

Test Plan and Hands on Testing

Changelog

  • Added "ignore all errors of this type this run" support for Error Recovery.

Risk assessment

low

@mjhuff mjhuff requested a review from a team July 31, 2024 16:58
@mjhuff mjhuff requested a review from a team as a code owner July 31, 2024 16:58
@mjhuff mjhuff requested review from brenthagen and removed request for a team and brenthagen July 31, 2024 16:58
sfoster1
sfoster1 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me!

@mjhuff mjhuff merged commit 0869f43 into edge Jul 31, 2024
26 checks passed
@mjhuff mjhuff deleted the app_ignore-error-this-run branch July 31, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjhuff @sfoster1