Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware): move pipette up out of liquid before requesting data buffer #15852

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Jul 31, 2024

Overview

When using the sync_buffer_output mode of liquid probe (which waits until after each liquid probe pass is over, and then sends all of the accumulated sensor data between passes), the pipette tip remains touching the top of the liquid while exchanging sensor data for a few seconds. This can cause unwanted liquid to enter the tip, so let's add a move that gets the pipette tip out of the liquid before the exchange of sensor data.

Changelog

  • in tool_sensors.py::run_sync_buffer_to_csv, if the initial move finished with ack stopped_by_condition, send a `raise_z' move_group

Test Plan

  • check that when using sync_buffer_output, the upward move happens at the appropriate time, and confirm that the buffer is sent immediately after
  • make sure this doesn't break other modes of liquid probe

@caila-marashaj caila-marashaj requested a review from a team as a code owner July 31, 2024 16:29
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@caila-marashaj caila-marashaj merged commit 9e6eb12 into edge Aug 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants