feat(components): migrate LocationIcon to DeckInfoLabel #15846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenthagen
requested review from
TamarZanzouri
and removed request for
a team and
TamarZanzouri
brenthagen
commented
Jul 31, 2024
Comment on lines
+313
to
+315
| ).withConfig({ | ||
| shouldForwardProp: p => p !== 'oddStyle' && p !== 'desktopStyle', | ||
| })` |
There was a problem hiding this comment.
@sfoster1 this un-forwards the non-style props and removes the console warnings Warning: React does not recognize the oddStyle prop on a DOM element.
sfoster1
approved these changes
Jul 31, 2024
Comment on lines
+313
to
+315
| ).withConfig({ | ||
| shouldForwardProp: p => p !== 'oddStyle' && p !== 'desktopStyle', | ||
| })` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
updates and renames the location icon component to reflect helix/ODD styles
closes PLAT-370, PLAT-408, RQA-2827
Test Plan and Hands on Testing
verified styles and updated unit tests
Changelog
Review requests
smoke test the various places the label appears, including deck map labels
Risk assessment
low