-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(robot-server, api): add router for creating run error recovery policies #15812
chore(robot-server, api): add router for creating run error recovery policies #15812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks. A handful of small changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me overall, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to merge, and here's some feedback on the description for the future.
Overview
part of https://opentrons.atlassian.net/browse/EXEC-302.
Closes EXEC-589.
add router for creating a error recovery policy for a run.
Test Plan
/runs/{runId}/policies
with payload:{ "data": "policyRules": [ { "matchCriteria": { "command": { "commandType": "aspirate", "error": { "errorType": "TipNotAttachedError" } } }, "ifMatch": "ignoreAndContinue" } ] }
should get a
NotImplementedError
until @SyntaxColoring finishes PE logic.Changelog
create_run_policies
toruns
router.run_data_manager
,run_orchestrator
and PE signature.Risk assessment
low.