Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): fix well depth for blowout field #15809

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jul 26, 2024

closes RESC-309

Overview

Good catch by the user here. instead of taking the well's depth, it was taking the labware's full height

Test Plan

Create an ot-2 or flex protocol and add a labware to the deck. make a transfer step and add a touchtip and blowout. verify that the touch tip tip position height and the blowout tip position height are the same.

Changelog

  • get well depth instead of z dimension

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner July 26, 2024 15:36
@jerader jerader requested a review from koji July 26, 2024 15:37
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked as expected

@jerader jerader merged commit 5615d1e into edge Jul 26, 2024
20 checks passed
@jerader jerader deleted the pd_fix-modal-height branch July 26, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants