Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): analyses snapshot skip pr on fail label #15792

Merged
merged 15 commits into from
Jul 25, 2024
Merged

feat(ci): analyses snapshot skip pr on fail label #15792

Changes from 4 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
200f9fa
feat(ci): analyses snapshot skip pr on fail label
y3rsh Jul 24, 2024
3a5ff4c
re-order and remove HEAD
y3rsh Jul 24, 2024
a567950
try again
y3rsh Jul 24, 2024
4282173
testing the label
y3rsh Jul 24, 2024
2a489da
Merge branch 'edge' into analyses-snapshots-more-options
y3rsh Jul 25, 2024
7152683
address feedback
y3rsh Jul 25, 2024
aaf2853
run the workflow when pr labled
y3rsh Jul 25, 2024
9509226
break a snapshot
y3rsh Jul 25, 2024
4d59bd9
make a change that will trigger
y3rsh Jul 25, 2024
0d6e22a
|| true will let it keep going?
y3rsh Jul 25, 2024
a3dfe42
revert snapshot
y3rsh Jul 25, 2024
32a2737
bad snap and better diff capture
y3rsh Jul 25, 2024
e6fc09d
had the if reversed with new conditional
y3rsh Jul 25, 2024
18eafa8
fix conditionals
y3rsh Jul 25, 2024
dd969d2
fix the snapshot
y3rsh Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions .github/workflows/analyses-snapshot-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ on:
- '!api/docs/**'
- 'shared-data/**/*'
- '!shared-data/js/**'
- '.github/workflows/analyses-snapshot-test.yaml'

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Expand All @@ -40,14 +41,28 @@ jobs:
# If we're running because of workflow_dispatch, use the user input to decide
# whether to open a PR on failure. Otherwise, there is no user input, so always
# open a PR on failure.
OPEN_PR_ON_FAILURE: ${{ (github.event_name == 'workflow_dispatch' && github.events.inputs.OPEN_PR_ON_FAILURE) || (github.event_name != 'workflow_dispatch') }}

OPEN_PR_ON_FAILURE: ${{ (github.event_name == 'workflow_dispatch' && github.events.inputs.OPEN_PR_ON_FAILURE) || ((github.event_name != 'workflow_dispatch') && !(contains(github.event.pull_request.labels.*.name, 'no-analyses-snapshot-pr'))) }}
PR_TARGET_BRANCH: ${{ github.event.pull_request.base.ref || 'not a pr'}}
steps:
- name: Checkout Repository
uses: actions/checkout@v4
with:
ref: ${{ env.SNAPSHOT_REF }}

- name: Are the analyses snapshots in my PR branch in sync with the target branch?
if: ${{ env.PR_TARGET_BRANCH != 'not a pr' }}
run: |
git fetch origin ${{ env.PR_TARGET_BRANCH }}
git diff --quiet HEAD origin/${{ env.PR_TARGET_BRANCH }} -- analyses-snapshot-testing/tests/__snapshots__/analyses_snapshot_test
DIFF_EXIT_CODE=$?
if [ $DIFF_EXIT_CODE -eq 0 ]; then
echo "Analyses snapshots match ${{ env.PR_TARGET_BRANCH }} snapshots."
else
echo "Analyses snapshots do NOT match ${{ env.PR_TARGET_BRANCH }} snapshots."
echo "Is this becasue you have not pulled and merged ${{ env.PR_TARGET_BRANCH }}?"
echo "Or is this because you have already updated your snapshots and are all good 😊?"
fi

- name: Docker Build
working-directory: analyses-snapshot-testing
run: make build-opentrons-analysis
Expand Down