-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(api): additional partial tip pickup layouts in 2.20 #15778
Conversation
ce8949a
to
7dbb338
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I did have some suggestions for consideration. What a feature!
@@ -21,7 +21,7 @@ Multi-Channel Movement | |||
|
|||
All :ref:`building block <v2-atomic-commands>` and :ref:`complex commands <v2-complex-commands>` work with single- and multi-channel pipettes. | |||
|
|||
To keep the protocol API consistent when using single- and multi-channel pipettes, commands treat the back left channel of a multi-channel pipette as its *primary channel*. Location arguments of pipetting commands use the primary channel. The :py:meth:`.InstrumentContext.configure_nozzle_layout` method can change the pipette's primary channel, using its ``start`` parameter. See :ref:`partial-tip-pickup` for more information. | |||
To keep the protocol API consistent when using single- and multi-channel pipettes, location arguments of pipetting commands use the pipette's *primary channel*. For multi-channel pipettes picking up tips with all of their channels, the back-left channel is considered primary. When using fewer channels, the ``start`` parameter of the :py:meth:`.InstrumentContext.configure_nozzle_layout` method can change the pipette's primary channel. See :ref:`partial-tip-pickup` for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest striking "considered" from this sentence:
"For multi-channel pipettes picking up tips with all of their channels, the back-left channel is considered primary."
Or even write it as, "...the back-left channel is the primary channel."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being subtle here. The choice of primary nozzle in ALL
configuration is implicit and can be overridden, although I'm pretty sure this is a bad idea:
8ch_pipette.configure_nozzle_layout(
style=ALL,
start="H1",
)
Consider the placement of your tip rack when choosing the ``start`` value for row pickup. The pipette cannot pick up from back to front (``start="H1"``) on tip racks in row A of the deck, nor can it pick up from front to back (``start="A1"``) on tip racks in row D of the deck. This is because the pipette can't move far enough backward or forward, respectively, to align over those tips. | ||
|
||
Use a different ``start`` value, or load the tip rack in row B or C. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not possible in a note::
in rst. This seems like an ideal case for bullets to emphasize the thing to avoid/not to do:
The pipette cannot pick up from:
- Back to front (
start="H1"
) on tip racks in row A of the deck. - Front to back (
start="A1"
) on tip racks in row D of the deck.
...
Also, recommend putting emphasis on cannot in the note text.
OK, merging this monster. If anything is amiss, I can do a follow-up. |
Overview
Document the new
ROW
,SINGLE
, andPARTIAL_COLUMN
configurations for partial tip pickup.Test Plan
Changelog
Review requests
Risk assessment
v low