fix(performance-metrics): fix dependency issues for performance metrics #15766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekMaggio
force-pushed
the
performance-metrics-specify-deps
branch
from
a046148 to
ce8f2e1
Compare
DerekMaggio
force-pushed
the
performance-metrics-specify-deps
branch
from
af2a525 to
a68a053
Compare
2 days. 2 days it took me to figure this out. So much logging, debugging and so many builds, for this. I had to literally go into the micropipenv source code to figure out why it was doing this. Its fixes like this that make me wish I could retire. But alas, I can't
DerekMaggio
changed the title
6 tasks
|
Not doing - just using grafana |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes issues with dependencies preventing robot OS builds from building successfully
Goes towards closing https://opentrons.atlassian.net/browse/EXEC-610
Related PRs:
Opentrons/oe-core#156
Test Plan
oe-corebuilds successfully against this branchsystem-resource-trackerstarts correctlysystem-resource-trackerrecords system resource usageReview requests
Is the content inside of INSTALL_REQUIRES in the setup.py of performance-metrics required? I have no idea if it is actually doing anything.
Risk assessment
Low