Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Add user input to enable/disable opening an analyses snapshot PR #15764

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

SyntaxColoring
Copy link
Contributor

Overview

Sometimes when you're running the analyses snapshot tests, you just want to run it and see the result without automatically opening a PR. This adds a checkbox to the "Run workflow" UI to do that.

Test Plan

  • It works with the checkbox deselected
  • It works with the checkbox selected

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner July 23, 2024 16:32
@SyntaxColoring SyntaxColoring requested a review from y3rsh July 23, 2024 16:34
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if it works but maybe add some parens for that comparison?

.github/workflows/analyses-snapshot-test.yaml Outdated Show resolved Hide resolved
Copy link
Member

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you.

@SyntaxColoring SyntaxColoring merged commit cad42e0 into edge Jul 23, 2024
5 checks passed
@SyntaxColoring SyntaxColoring deleted the conditionally_open_snapshot_pr branch July 23, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants