Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(robot-server): fetch all CSV files used with a protocol recently #15756

Conversation

sanni-t
Copy link
Member

@sanni-t sanni-t commented Jul 23, 2024

Closes AUTH-428

Overview

Adds a new endpoint GET /protocols/{protocolId}/dataFiles which provides a list of all data files used as CSV parameters for the provided protocol. It determines the files used based on the CSV files used and saved in previous analyses.

Test Plan

  • Upload some data files and use them as csv params for a protocol with CSV params. Use different files in different analysis.
  • Check that the new endpoint returns the correct list of data files used

Review requests

Usual code sanity check

Risk assessment

Low. New endpoint and isolated feature.

@sanni-t sanni-t requested review from a team as code owners July 23, 2024 15:04
@sanni-t sanni-t changed the base branch from edge to AUTH-527-move-rtps-to-their-own-table July 23, 2024 15:05
@sanni-t sanni-t changed the base branch from AUTH-527-move-rtps-to-their-own-table to AUTH-416-accept-csv-file-ids-and-save-to-csv-table July 23, 2024 15:06
@sanni-t sanni-t changed the title Auth 428 fetch all csvs belonging to a protocol feat(robot-server): fetch all CSV files used with a protocol recently Jul 23, 2024
@sanni-t sanni-t force-pushed the AUTH-416-accept-csv-file-ids-and-save-to-csv-table branch from 5282993 to c7fff38 Compare July 23, 2024 18:41
@sanni-t
Copy link
Member Author

sanni-t commented Jul 23, 2024

Messed up the git history of this branch. Going to close this PR and open a new one.

@sanni-t sanni-t closed this Jul 23, 2024
@sanni-t sanni-t deleted the AUTH-428-fetch-all-csvs-belonging-to-a-protocol branch July 30, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant