Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add sorting function for csv files #15749

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Jul 22, 2024

Overview

add sorting function for csv files

[before]
Screenshot 2024-07-22 at 5 56 22 PM

[after]
https://github.com/user-attachments/assets/b14217cd-dd4e-4767-9773-a4ea93b0d6df

close AUTH-578

Test Plan

Changelog

Review requests

Risk assessment

low

add sorting function for csv files

close AUTH-578
@koji koji requested review from ncdiehl11 and jerader July 22, 2024 21:58
@koji koji marked this pull request as ready for review July 22, 2024 22:55
@koji koji requested a review from a team as a code owner July 22, 2024 22:55
@koji koji removed the request for review from a team July 22, 2024 22:55
@@ -57,6 +78,7 @@ export function ChooseCsvFile({

const handleBackButton = (): void => {
if (!isEqual(csvFileSelected, initialFileObject)) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is suddenly needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on my end

Unsafe argument of type `any` assigned to a parameter of type `string`.eslint[@typescript-eslint/no-unsafe-argument](https://typescript-eslint.io/rules/no-unsafe-argument)

maybe as string would be better than eslint-disabled.

@koji koji requested a review from jerader July 27, 2024 02:58
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm!

@koji koji merged commit 8cd0507 into edge Jul 29, 2024
24 checks passed
@koji koji deleted the feat_add-sorting-to-choose-csv-file branch July 29, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants