Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: disable sign without failing builds #15743

Merged
merged 1 commit into from
Jul 23, 2024
Merged

build: disable sign without failing builds #15743

merged 1 commit into from
Jul 23, 2024

Conversation

sfoster1
Copy link
Member

Edge needs to be able to produce builds that aren't signed now.

@sfoster1
build: disable sign without failing builds
b75bfe5 
Edge needs to be able to produce builds that aren't signed now.
@sfoster1 sfoster1 marked this pull request as ready for review July 22, 2024 21:16
@sfoster1 sfoster1 requested a review from a team as a code owner July 22, 2024 21:16
@sfoster1 sfoster1 requested review from jerader and removed request for a team July 22, 2024 21:16
@sfoster1
Copy link
Member Author

Does do a build! https://github.com/Opentrons/opentrons/actions/runs/10048088008/job/27771277118

@sfoster1 sfoster1 requested a review from y3rsh July 22, 2024 21:17
@sfoster1 sfoster1 merged commit 325c867 into edge Jul 23, 2024
64 checks passed
@sfoster1 sfoster1 deleted the fix-develop-builds-no-codesigning-app-build-both branch July 23, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegano1 vegano1 vegano1 approved these changes

@y3rsh y3rsh y3rsh approved these changes

@jerader jerader Awaiting requested review from jerader jerader is a code owner automatically assigned from Opentrons/js

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfoster1 @y3rsh @vegano1