Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix navigation menu display position issue #15734

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented Jul 22, 2024

Overview

fix navigation menu display position issue

close RQA-2864

odd_mini_modal.mov

Test Plan

  1. run Flex robot-server
  2. run odd mode
  3. go to settings screen
  4. tap overflow menu in the right corner
    check menu is opened correctly
  5. scroll down to the end of the screen and tap the overflow menu again
    check menu is opened in viewport

Changelog

Review requests

Risk assessment

low

fix navigation menu display position issue

close RQA-2864
@koji koji requested review from ncdiehl11 and jerader July 22, 2024 16:48
@koji koji marked this pull request as ready for review July 22, 2024 16:49
@koji koji requested a review from a team as a code owner July 22, 2024 16:49
@koji koji removed the request for review from a team July 22, 2024 16:49
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@koji koji merged commit a6bf864 into edge Jul 22, 2024
26 checks passed
@koji koji deleted the fix_RQA-2864 branch August 8, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants