Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): replace Flex+icon+text with Chip #15728

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Jul 20, 2024

Overview

replace Flex+icon+text with Chip

At this moment, csv required isn't available because still analysis part has been updated.

Screenshot 2024-07-20 at 2 37 44 PM

close RSQ-130

Test Plan

Changelog

Review requests

Risk assessment

low

@koji koji requested review from ncdiehl11 and jerader July 20, 2024 18:42
@koji
Copy link
Contributor Author

koji commented Jul 20, 2024

  • fix test errors

@koji koji marked this pull request as ready for review July 22, 2024 15:28
@koji koji requested a review from a team as a code owner July 22, 2024 15:28
@koji koji removed the request for review from a team July 22, 2024 15:28
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@koji koji merged commit 3c74322 into edge Jul 22, 2024
24 checks passed
@koji koji deleted the refactor_odd-protocol-card-for-chip branch July 22, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants