Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(abr-testing): increase number of lines of logs saved during error #15680

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix(abr-testing): increase number of lines of logs saved during error #15680

merged 1 commit into from
Jul 16, 2024

Conversation

rclarke0
Copy link
Contributor

Overview

Increase record # for log downloading during ABR error

Test Plan

Changelog

  • moved get_logs to beginning of error script so logs are pulled immediately
  • increase number of lines pulled for each log type

Review requests

Risk assessment

@rclarke0 rclarke0 requested a review from a team as a code owner July 16, 2024 19:07
@rclarke0 rclarke0 requested review from a team and caila-marashaj July 16, 2024 19:07
caila-marashaj
caila-marashaj approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@caila-marashaj caila-marashaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@rclarke0 rclarke0 merged commit 0ba6c79 into edge Jul 16, 2024
11 checks passed
@rclarke0 rclarke0 deleted the increase-log-records branch July 16, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caila-marashaj caila-marashaj caila-marashaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rclarke0 @caila-marashaj