Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(robot-server): move run time params to their own DB table #15650
refactor(robot-server): move run time params to their own DB table #15650
Changes from 9 commits
fceb9f7
47bc6ee
234ea8f
f828e90
1d06cbf
0e8e8f3
91e83a6
6218337
97bedf3
d6f61c6
b2d8d4f
c3fae51
3a090c7
1ab3fc2
08567c7
4f8bf23
69c135d
bbf2a9d
e32e371
262db4b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: I think this is harmless, but
order_by_rowid
can beFalse
forrun_command_table
because it has explicitly-declaredrow_id
andindex_in_run
columns.I wonder if
order_by_rowid=True
is actually any slower or more memory-hungry than=False
. Maybe it should just always beTrue
to simplify things.