Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): need always in workflow conditional for analyses snapshot fa… #15607

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Jul 9, 2024

always() left out

These steps won't run unless always() is included in the step conditional if the workflow had a previous step fail.

@y3rsh y3rsh self-assigned this Jul 9, 2024
@y3rsh y3rsh requested a review from a team as a code owner July 9, 2024 20:25
@y3rsh
Copy link
Member Author

y3rsh commented Jul 9, 2024

Used this branch as the source of the workflow file for this run of the tests to prove this fix.

https://github.com/Opentrons/opentrons/actions/runs/9863715749

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love YAML control flow.

@y3rsh y3rsh merged commit adcfa12 into edge Jul 9, 2024
10 of 11 checks passed
@y3rsh y3rsh deleted the analyses-test-handle-failure branch July 9, 2024 20:44
syao1226 pushed a commit that referenced this pull request Jul 10, 2024
#15607)

## always() left out

These steps won't run unless `always()` is included in the step
conditional if the workflow had a previous step fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants