Upgrade to aionotify 0.3.1 #15546
Merged
Upgrade to aionotify 0.3.1 #15546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
added a commit
to Opentrons/buildroot
that referenced
this pull request
Jun 28, 2024
Bump to match Opentrons/opentrons#15546 for 3.11 compatibility in the monorepo
sfoster1
added a commit
to Opentrons/oe-core
that referenced
this pull request
Jun 28, 2024
Bump to match Opentrons/opentrons#15546 for monorepo 3.11 compat
|
I pushed https://github.com/Opentrons/opentrons/tree/edge-15546 because we need it in our remote for the robot builds, but this is the PR we'll merge |
sfoster1
added a commit
to Opentrons/buildroot
that referenced
this pull request
Jun 28, 2024
Bump to match Opentrons/opentrons#15546 for 3.11 compatibility in the monorepo
sfoster1
added a commit
to Opentrons/oe-core
that referenced
this pull request
Jun 28, 2024
Bump to match Opentrons/opentrons#15546 for monorepo 3.11 compat
|
@sfoster1 Thanks for taking over! Did this end up in the new v7.4.0 release? I can't spot it in the changes v7.3.1...v7.4.0, but maybe that's because of how you're building releases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
opentronsPython package is not yet compatible with Python 3.11. It raises errors upon import, which forces scientists to use the soon to be outdated Python 3.10.The
aionotifydependency has since been updated for Python 3.11 compatibility, so just a dependency upgrade is needed.Test Plan
Changelog
aionotifyto current version 0.3.1Review requests
I'm not familiar with how this repository is organized, or how the Python package ending up on PyPI is built.
I hope that the CI pipeline turns green, and that maintainers can take over from there. Hopefully this remains a really easy fix for the long-standing compatibility issue #12006.
Risk assessment