Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai-server): use env variables for the cpu and memory of the task #15530

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Jun 26, 2024

Use variables for cpu and memory

Note

It is easy to increase the number of tasks running in a given cluster with the AWS console so we won't automate that part now.

  • Add cpu and memory to settings and use the value at task definition creation
  • Update dev env variables secret
  • Update prod env variables secret

Once merged

  1. see that staging has the correct values.
  2. tag and see the prod deployment has the correct values.

@y3rsh y3rsh self-assigned this Jun 26, 2024
@y3rsh y3rsh requested a review from a team as a code owner June 26, 2024 18:52
@y3rsh y3rsh requested a review from a team as a code owner June 26, 2024 19:04
Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@y3rsh y3rsh merged commit 77efeaf into edge Jun 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants