-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app, labware-library, app-shell): Labware creator in app prototype #15485
Conversation
cbf2afc
to
8571f8d
Compare
8571f8d
to
16e527c
Compare
@@ -10,7 +10,7 @@ import { versionForProject } from '../scripts/git-version.mjs' | |||
import type { UserConfig } from 'vite' | |||
|
|||
export default defineConfig( | |||
async(): Promise<UserConfig> => { | |||
async (): Promise<UserConfig> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier adds this space 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting
maybe Brian did update eslint config on prettier recently 🤔
labware-library/src/labware-creator/components/ImportLabware.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments.
this pr is stunning!
…pe (#15485) This is the _InT3rNaL pRoTOtyP3_ of putting Labware Creator in the app and it is behind the feature flag
Overview
While working on LC the past few weeks I realized that putting it in the app is actually a fairly easy task. This is the InT3rNaL pRoTOtyP3 🤫 and it is behind the feature flag ❤️
Screen.Recording.2024-06-21.at.10.10.55.mov
Test Plan
Changelog
Labware
in the appReview requests
Risk assessment
low, it is behind a ff