Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app, labware-library, app-shell): Labware creator in app prototype #15485

Merged
merged 12 commits into from
Jul 2, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Jun 21, 2024

Overview

While working on LC the past few weeks I realized that putting it in the app is actually a fairly easy task. This is the InT3rNaL pRoTOtyP3 🤫 and it is behind the feature flag ❤️

Screen.Recording.2024-06-21.at.10.10.55.mov

Test Plan

  • build ur dependencies!
  • Turn on the Enable App Labware Creator feature flag
  • go to the Labware tab
  • click on the Open Labware Creator button
  • it should launch a wizard with the LC pages on each page and skipping the pages if the specs you've entered don't work
  • there should be some error handling where the banner pops up if your field is missing or incorrect and the next button should be disabled if that is the case
  • once you create the definition, it should auto-populate in the Custom Labware section of the Labware library
  • click on that labware and open the slideout and inspect the slideout specs
  • then launch the wizard again and click on "upload a file that you've created" and upload a labware file (it does not direct to the folder that your labware was added to -- need to think about how to approach that more) but after you upload it should populate in the wizard
  • test labware-creator in the dev environment to make sure it has retained the designs and functionality

Changelog

  • make feature flag
  • create modal branching logic in LC
  • make LL a module that app package.json imports
  • edit the configs so LL is treated like a module
  • add the button to Labware in the app
  • add some new redux selectors in app-shell and app so they it takes in a string of the json file instead of importing a file
  • fix cypress tests
  • fix unit tests

Review requests

Risk assessment

low, it is behind a ff

@jerader jerader changed the title feat(app): Labware creator in app prototype feat(app, labware-library, app-shell): Labware creator in app prototype Jun 21, 2024
@jerader jerader marked this pull request as ready for review June 21, 2024 13:47
@jerader jerader requested review from a team as code owners June 21, 2024 13:47
@jerader jerader requested review from smb2268, b-cooper and shlokamin and removed request for a team June 21, 2024 13:47
@jerader jerader force-pushed the app_labware-creator-in-app-prototype branch from cbf2afc to 8571f8d Compare June 21, 2024 17:29
@jerader jerader requested review from koji and ncdiehl11 and removed request for a team and b-cooper July 2, 2024 14:25
@jerader jerader force-pushed the app_labware-creator-in-app-prototype branch from 8571f8d to 16e527c Compare July 2, 2024 16:12
@@ -10,7 +10,7 @@ import { versionForProject } from '../scripts/git-version.mjs'
import type { UserConfig } from 'vite'

export default defineConfig(
async(): Promise<UserConfig> => {
async (): Promise<UserConfig> => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need space?

Copy link
Collaborator Author

@jerader jerader Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier adds this space 🤔

Copy link
Contributor

@koji koji Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting
maybe Brian did update eslint config on prettier recently 🤔

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments.
this pr is stunning!

@jerader jerader merged commit 0e7effd into edge Jul 2, 2024
22 checks passed
@jerader jerader deleted the app_labware-creator-in-app-prototype branch July 2, 2024 17:16
aaron-kulkarni pushed a commit that referenced this pull request Jul 3, 2024
…pe (#15485)

This is the _InT3rNaL pRoTOtyP3_ of putting Labware Creator in the app and it is behind the feature flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants