Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(robot-server): redirect maintenance engine/runner calls via run orchestrator #15397

Merged
merged 6 commits into from
Jun 12, 2024
Merged

refactor(robot-server): redirect maintenance engine/runner calls via run orchestrator #15397

merged 6 commits into from
Jun 12, 2024

Conversation

TamarZanzouri
Copy link
Contributor

Overview

phase 3-> maintenance router engine_store and run_data_manager.

Test Plan

  • All tavern tests are passing.
  • tested with dev server and POSTing commands.

Changelog

  • Use RunOrchestrator instead of using engine/runners in MaintenanceEngineStore and RunDataManager.

Risk assessment

low. use RunOrchestrator instead of using engine/runners.

@TamarZanzouri TamarZanzouri requested a review from a team as a code owner June 12, 2024 13:26
@TamarZanzouri TamarZanzouri changed the title Exec 418 maintenance orchestrator refactor(robot-server): redirect engine/runner calls via run orchestrator Jun 12, 2024
@TamarZanzouri TamarZanzouri changed the title refactor(robot-server): redirect engine/runner calls via run orchestrator refactor(robot-server): redirect maintenance engine/runner calls via run orchestrator Jun 12, 2024
sfoster1
sfoster1 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice nice, much easier the second time around!

@TamarZanzouri TamarZanzouri merged commit 7f872f0 into edge Jun 12, 2024
20 checks passed
@TamarZanzouri TamarZanzouri deleted the exec-418-maintenance-orchestrator branch June 12, 2024 15:09
aaron-kulkarni pushed a commit that referenced this pull request Jun 13, 2024
@TamarZanzouri @aaron-kulkarni
refactor(robot-server): redirect maintenance engine/runner calls via …
c9184fb 
…run orchestrator (#15397)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

@SyntaxColoring SyntaxColoring Awaiting requested review from SyntaxColoring

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TamarZanzouri @sfoster1