-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(opentrons-ai-client) fix textarea overlapping issue #15307
Conversation
{isUser ? ( | ||
<Markdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry if this is obvious, but why do we conditionally change styles if the role is user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reason we need to use conditional here is that we don't display code hight lighter in user prompt.
oops, this shouldn't be in the PR.
#15308
I think we can do something like this.
<Markdown
components={{
div: undefined,
ul: UnnumberedListText,
h2: HeaderText,
li: ListItemText,
p: ParagraphText,
a: ExternalLink,
code: isUser ? undeifned : CodeText,
}}
>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Opentrons/opentrons/pull/15308/files
I'm going to remove this conditional statement from the PR.
Overview
fix Textarea overlapping issue and fix auto scrolling.
attached the video to the ticket since I cannot upload the big video to Github.
close AUTH-435
Test Plan
Changelog
Review requests
Risk assessment
low