Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentrons-ai-client) fix textarea overlapping issue #15307

Merged
merged 6 commits into from
May 31, 2024
Merged

Conversation

koji
Copy link
Contributor

@koji koji commented May 31, 2024

Overview

fix Textarea overlapping issue and fix auto scrolling.

attached the video to the ticket since I cannot upload the big video to Github.

close AUTH-435

Test Plan

  • run the app
  • send a few prompts

Changelog

  • update height to fix the overlapping issue
  • rename component name (ChatContainer -> MainContentContainer)

Review requests

Risk assessment

low

@koji koji marked this pull request as ready for review May 31, 2024 19:07
@koji koji requested a review from a team as a code owner May 31, 2024 19:07
Comment on lines 68 to 69
{isUser ? (
<Markdown
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry if this is obvious, but why do we conditionally change styles if the role is user?

Copy link
Contributor Author

@koji koji May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason we need to use conditional here is that we don't display code hight lighter in user prompt.

oops, this shouldn't be in the PR.
#15308

I think we can do something like this.

<Markdown
            components={{
              div: undefined,
              ul: UnnumberedListText,
              h2: HeaderText,
              li: ListItemText,
              p: ParagraphText,
              a: ExternalLink,
              code: isUser ? undeifned : CodeText,
            }}
          >

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Opentrons/opentrons/pull/15308/files

I'm going to remove this conditional statement from the PR.

@koji koji merged commit 1c76569 into edge May 31, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants