fix(opentrons-ai-client): fix example buttons and clear text after submitting prompt #15299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes closes Auth 434 and AUTH 437
shlokamin
changed the title
koji
reviewed
May 31, 2024
koji
reviewed
May 31, 2024
| const render = (props: React.ComponentProps<typeof PromptButton>) => { | ||
| return renderWithProviders(<PromptButton {...props} />) | ||
| } | ||
|
|
||
| let mockSetValue = vi.fn() |
There was a problem hiding this comment.
Suggested change
| let mockSetValue = vi.fn() | |
| const mockSetValue = vi.fn() |
koji
reviewed
May 31, 2024
| beforeEach(() => { | ||
| props = { | ||
| buttonText: 'Reagent Transfer', | ||
| } | ||
| mockSetValue = vi.fn() |
There was a problem hiding this comment.
Suggested change
| mockSetValue = vi.fn() |
koji
reviewed
May 31, 2024
koji
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes AUTH-434 and AUTH-437
This PR fixes the example buttons and clears the input prompt text after clicking the submit button.
I also removed the unnecessary jotai state variable that was holding onto prompt button text because the prompt button can access the form directly. This allows us to get rid of an unnecessary useEffect which was just listening for changes to the state variable and setting form state with the updated state variable value.
Also, testing react-hook-form is a massive pain. sometimes we need to mock internals, and sometimes we want to test full integration. I introuced patterns for both in this PR. Though honestly I'm not even convinced we need react hook form. Ideally we can get rid of both that and jotai
Changelog
Review requests
Risk assessment
Low