fix(protocol-designer): set numMultiples to numItems instead of 0 #15286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
koji,
a team and
sanni-t
and removed request for
a team
koji
approved these changes
May 29, 2024
There was a problem hiding this comment.
lgtm
tested all cases and the button worked as expected.
great job, @DerekMaggio!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-2787
Overview
This was a good catch by @DerekMaggio! Basically, the
numMultipleswas being set to 0 on render instead of remembering the actual number. So if you go back to change something, thenumMultipleswould be reset to 0, disallowing the user to select the down arrow.Test Plan
follow the test plan outlined in the attached ticket!
Changelog
useStatecorrectlyReview requests
see test plan
Risk assessment
low