Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data): defaults should match valuesByApiLevel for p50 3_6 lowVolume #15280

Merged
merged 1 commit into from
May 29, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented May 29, 2024

closes RQA-2785

Overview

Somehow i forgot to change the defaults for the p50 3_6 pipette version to match the uiMaxFlowRate and valuesByApiLevel. I double checked and this is the only model with the issue.

Test Plan

Just confirm that the defaults matches the valuesByApiLevel

Changelog

  • change pipette definition

Review requests

see test plan

Risk assessment

low

@jerader jerader requested a review from a team as a code owner May 29, 2024 16:19
@jerader jerader requested a review from sfoster1 May 29, 2024 16:20
Copy link
Contributor

@DerekMaggio DerekMaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The award for fastest ticket report time to fix time of 3 minutes goes to @jerader. Compared to other pipettes and the pattern of default == valuesByAPILevel is used on other pipettes

@jerader jerader merged commit 41f6945 into edge May 29, 2024
52 of 53 checks passed
@jerader jerader deleted the sd_fix-default-low-volume branch May 29, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants