refactor(app): add InterventionModal to Error Recovery #15277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
requested review from
TamarZanzouri and
a team
and removed request for
a team
koji
reviewed
May 29, 2024
Comment on lines
+21
to
+22
| import { getIsOnDevice } from '../../redux/config' | ||
|
|
There was a problem hiding this comment.
can you move this import before import type?
There was a problem hiding this comment.
Oh woops, I'll refactor this in my next PR 👍
koji
reviewed
May 29, 2024
| {...HEADER_STYLE} | ||
| backgroundColor={headerColor} | ||
| justifyContent={headerJustifyContent} | ||
| onClick={props.iconHeadingOnClick} |
There was a problem hiding this comment.
Can we destruct props instead of using props. ?
There was a problem hiding this comment.
Sure, can add in my next PR. Sorry I didn't see these in time 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-464
Overview
This PR adds the
InterventionModalmolecule to recovery flows.The
InterventionModalmolecule required light refactoring to meet new designs and to have proper height/width on the ODD. There will be a pop-up modal-within-modal that the ER Intervention modal will need to support, but that is a separate ticket. Only theonClickfunctionality is added here.Screen.Recording.2024-05-29.at.9.21.38.AM.mov
Test Plan
Risk assessment
low