feat(api): add protocol api and engine support for absorbance plate reader #15266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahiuchingau
force-pushed
the
abs96_protocol-engine
branch
2 times, most recently
from
18945e6 to
4d43e40
Compare
ahiuchingau
force-pushed
the
abs96_protocol-engine
branch
from
4d43e40 to
0c7d7d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #15266 +/- ##
===========================================
+ Coverage 63.20% 81.48% +18.28%
===========================================
Files 287 118 -169
Lines 14891 4078 -10813
===========================================
- Hits 9412 3323 -6089
+ Misses 5479 755 -4724
Flags with carried forward coverage won't be shown. Click here to find out more. |
vegano1
reviewed
Jun 5, 2024
api/src/opentrons/hardware_control/modules/absorbance_reader.py
Outdated
Show resolved
Hide resolved
vegano1
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
I reviewed the hardware controller and protocol engine integration, that looks good to me.
As for the docs failing, I think you just have to add the AbsorbanceReaderContext to the returns list of module context in the load_module docstring here.
b-cooper
reviewed
Jun 10, 2024
api/src/opentrons/hardware_control/modules/absorbance_reader.py
Outdated
Show resolved
Hide resolved
b-cooper
reviewed
Jun 10, 2024
| MeasureAbsorbanceParams, SuccessData[MeasureAbsorbanceResult, None] | ||
| ] | ||
| ): | ||
| """Execution implementation of a Thermocycler's run profile command.""" |
There was a problem hiding this comment.
copypasta comment needs replacing
b-cooper
reviewed
Jun 10, 2024
b-cooper
reviewed
Jun 10, 2024
b-cooper
reviewed
Jun 10, 2024
api/tests/opentrons/protocol_api/core/engine/test_absorbance_reader_core.py
Outdated
Show resolved
Hide resolved
b-cooper
reviewed
Jun 10, 2024
api/tests/opentrons/protocol_engine/commands/test_load_module.py
Outdated
Show resolved
Hide resolved
b-cooper
reviewed
Jun 10, 2024
api/tests/opentrons/protocol_engine/commands/test_load_module.py
Outdated
Show resolved
Hide resolved
b-cooper
reviewed
Jun 10, 2024
shared-data/command/schemas/8.json
Outdated
| "properties": { | ||
| "moduleId": { | ||
| "title": "Moduleid", | ||
| "description": "Unique ID of the Thermocycler.", |
There was a problem hiding this comment.
This is pulled from the docstring in the protocol engine command, so it should be fixed there
b-cooper
reviewed
Jun 10, 2024
b-cooper
reviewed
Jun 10, 2024
ahiuchingau
force-pushed
the
abs96_protocol-engine
branch
from
12cb466 to
acdf35b
Compare
jerader
reviewed
Jun 12, 2024
protocol-designer/src/components/modals/CreateFileWizard/ModulesAndOtherTile.tsx
Outdated
Show resolved
Hide resolved
jerader
approved these changes
Jun 12, 2024
aaron-kulkarni
pushed a commit
that referenced
this pull request
Jun 13, 2024
…eader (#15266) # Overview This PR adds protocol api and engine support for absorbance plate reader. Requires OE-core changes in Opentrons/oe-core#151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds protocol api and engine support for absorbance plate reader.
Requires OE-core changes in Opentrons/oe-core#151
Test Plan
Changelog
Backend changes:
AbsorbanceReaderCoreas a new module core in the protocol apidef initialize(wavelength: int):to allow for reference wavelengthsdef initiate_read():to actually get a 96 sample absorbance reading from the plate readerinitializeandinitiate_readFrontend changes:
Shared-data changes:
closes PLAT-336