Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): validation casing for mixed tip use between single and eight channels #15259

Conversation

CaseyBatten
Copy link
Contributor

Overview

Closes RQA-2780
An edge case was found where the automatic tip tracking would not correctly identify the next valid column for an 8ch pickup after a sequence of single channel pickups.

Test Plan

The following protocol should pass analysis and perform identically on apiLevel 2.17 and 2.18.

requirements = {
	"robotType": "Flex",
	"apiLevel": "2.18"
}

def run(ctx):
	tips = ctx.load_labware('opentrons_flex_96_tiprack_1000ul', 'B3')
	tips2 = ctx.load_labware('opentrons_flex_96_tiprack_1000ul', 'C3')
	p1000 = ctx.load_instrument('flex_8channel_1000', 'right', tip_racks=[tips, tips2]) 
	p1000_single = ctx.load_instrument('flex_1channel_1000', 'left', tip_racks=[tips, tips2])
	trash = ctx.load_trash_bin("A3")

	p1000_single.pick_up_tip()
	p1000_single.drop_tip()
	p1000_single.pick_up_tip()
	p1000_single.drop_tip()

	for i in range(22):
		p1000.pick_up_tip()
		p1000.drop_tip()

Changelog

Review requests

Risk assessment

Low

@CaseyBatten CaseyBatten requested a review from a team as a code owner May 23, 2024 20:15
Copy link
Contributor

@jbleon95 jbleon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, should add a unit test to catch this but this is good for 7.3

@CaseyBatten CaseyBatten merged commit 2afa859 into chore_release-7.3.0 May 23, 2024
20 checks passed
@CaseyBatten CaseyBatten deleted the single-channel-to-eight-channel-mixed-pickup-fix branch May 24, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants